Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: pure Python 3 wheel #21

Closed
simonw opened this issue Oct 16, 2021 · 6 comments
Closed

Feature request: pure Python 3 wheel #21

simonw opened this issue Oct 16, 2021 · 6 comments

Comments

@simonw
Copy link

simonw commented Oct 16, 2021

I tried to install a package that depends on this inside JupyterLite and got the following error:

Couldn't find a pure Python 3 wheel for 'click-default-group'

Steps to reproduce: navigate to https://jupyterlite.github.io/demo/lab/index.html and run the following:

import micropip
await micropip.install("sqlite-utils")
@simonw
Copy link
Author

simonw commented May 2, 2022

I ported a subset of the test suite to GitHub Actions as part of this - https://github.com/simonw/click-default-group-wheel/blob/master/.github/workflows/test.yml - though I didn't get coveralls or Click version 8.0+ working there.

You're welcome to take my test.yml file and adapt it for this project if you want to move away from Travis.

@simonw
Copy link
Author

simonw commented May 2, 2022

I've published a package to PyPI under the name click-default-group-wheel to unblock my project on this:

I'll happily retire my package (my replacing it with a version that just depends back on click-default-group using the pattern for pypi-rename) when a version of click-default-group ships with a wheel.

I used my new package to ship a new version of sqlite-utils with that dependency - which means it now works in both JupyterLite and in the Pyodide REPL!

https://sqlite-utils.datasette.io/en/stable/changelog.html#v3-26-1

Visit https://pyodide.org/en/stable/console.html and try the following:

>>> import micropip
>>> await micropip.install("sqlite-utils")
>>> import sqlite_utils
>>> db = sqlite_utils.Database(memory=True)
>>> list(db.query("select 3 * 5"))
[{'3 * 5': 15}]

@webknjaz
Copy link

webknjaz commented Aug 4, 2023

@simonw the wheel is now published. Though, it's tagged as py2.py3.

@simonw
Copy link
Author

simonw commented Sep 6, 2023

Nice! This is great, thank you.

https://pypi.org/project/click-default-group/1.2.3/#files

CleanShot 2023-09-05 at 19 31 31@2x

@simonw simonw closed this as completed Sep 6, 2023
simonw added a commit to simonw/datasette that referenced this issue Sep 6, 2023
simonw added a commit to simonw/sqlite-utils that referenced this issue Sep 6, 2023
simonw added a commit to simonw/llm that referenced this issue Sep 6, 2023
simonw added a commit to simonw/click-default-group-wheel that referenced this issue Sep 6, 2023
simonw added a commit to simonw/datasette that referenced this issue Sep 6, 2023
* click-default-group>=1.2.3

Now available as a wheel:
- click-contrib/click-default-group#21

* Fix for blacken-docs
@simonw
Copy link
Author

simonw commented Sep 6, 2023

I've retired my https://github.com/simonw/click-default-group-wheel repo.

@simonw
Copy link
Author

simonw commented Sep 6, 2023

I published one last click-default-group-wheel package that simply depends on this one - transcript of that here:

https://github.com/simonw/pypi-rename/blob/22e603bf1fc57f54d52c9ef1b361f841e8052f8f/README.md#publishing-your-renamed-package-to-pypi

Package is here: https://pypi.org/project/click-default-group-wheel/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants