test(test_miscellaneous): added a missing test for class FirstOf

There was a missing test to check the name of the custom type given at instantiation level

click_params/miscellaneous.py

@@ -83,13 +83,13 @@ class FirstOf(CustomParamType):
     def __init__(self, *param_types: click.ParamType, name: Optional[str] = None, return_param: bool = False):
         self.param_types = param_types
         self.return_param = return_param
-        if not getattr(self, "name", None):
+        if not getattr(self, 'name', None):
             if name:
                 self.name = name
             else:
                 # Set name to union representation of individual params.
-                # Using pipe | as thats used by python sets for union.
-                self.name = "(" + " | ".join(p.name for p in self.param_types) + ")"
+                # Using pipe | as that is used by python sets for union.
+                self.name = '(' + ' | '.join(p.name for p in self.param_types) + ')'
 
     def convert(
         self, value: str, param: Optional[click.Parameter], ctx: Optional[click.Context]
@@ -104,13 +104,13 @@ def convert(
                 fails.append((param_type, str(e)))
 
         self.fail(
-            "All possible options exhausted without any successful conversion:\n - "
+            'All possible options exhausted without any successful conversion:\n - '
             + "\n - ".join(
                 [
                     indent(
                         f"{getattr(f[0], 'name', f[0].__class__.__name__).upper()}:"
-                        f" {f[1]}",
-                        " ",
+                        f' {f[1]}',
+                        ' ',
                     )
                     for f in fails
                 ]

tests/test_miscellaneous.py

@@ -140,7 +140,8 @@ class CoreNumber(FirstOf):
             name = 'core number'
 
         assert 'CORE NUMBER' == repr(CoreNumber(click.INT, click.Choice(['all', 'half'])))
-        assert "(INTEGER | CHOICE)" == repr(FirstOf(click.INT, click.Choice(['all', 'half'])))
+        assert 'CORE NUMBER' == repr(FirstOf(click.INT, click.Choice(['all', 'half']), name='core number'))
+        assert '(INTEGER | CHOICE)' == repr(FirstOf(click.INT, click.Choice(['all', 'half'])))
 
     @pytest.mark.parametrize(('expression', 'param_types', 'value'), [
         ('12', (click.INT,), 12),
@@ -165,7 +166,7 @@ def test_should_parse_expression_successfully(self, expression, param_types, val
         ('12', (click.Choice(['auto', 'full']), click.INT), click.INT),
         ('12.3', (click.Choice(['auto', 'full']), click.INT, click.FLOAT), click.FLOAT)
     ])
-    def test_should_return_correct_paramtype(self, expression, param_types, expected_param_type):
+    def test_should_return_correct_param_type(self, expression, param_types, expected_param_type):
         union_type = FirstOf(*param_types, return_param=True)
         (param_type, _) = union_type.convert(expression, None, None)
         assert repr(expected_param_type) == repr(param_type)
@@ -177,5 +178,5 @@ def test_should_return_correct_paramtype(self, expression, param_types, expected
     ])
     def test_should_parse_expression_unsuccessfully(self, expression, param_types):
         union_type = FirstOf(*param_types)
-        with pytest.raises(click.BadParameter, match=r'.*\n -  '.join(p.name.upper() for p in param_types)) as e:
+        with pytest.raises(click.BadParameter, match=r'.*\n -  '.join(p.name.upper() for p in param_types)):
             union_type.convert(expression, None, None)