Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix behavior of show_default with context_settings #131

Closed
wants to merge 10 commits into from

Conversation

dylanpilz
Copy link

@dylanpilz dylanpilz commented Feb 27, 2024

Summary

Implemented changes requested in #115.
Closes #114, closes #115

Tasks

  • Added unit tests
  • Added documentation for new features (where applicable)
  • Added release notes (using reno)
  • Ran test suite and style checks and built documentation (tox)

Further details

Command.show_defaults overrides show_default, consistent with click version 8.1x

@dylanpilz
Copy link
Author

@stephenfin Feel free to take a look at your earliest convenience. Would be great to finally put this to rest

@dylanpilz dylanpilz marked this pull request as draft March 7, 2024 18:56
@dylanpilz dylanpilz marked this pull request as ready for review March 14, 2024 16:14
@stephenfin
Copy link
Member

stephenfin commented Apr 5, 2024

Apologies for the delay on this. Can you rebase onto master, squash the commits and run black to fix the lint issues (pre-commit run -a will do the trick). Happy to merge once that's done.

@stephenfin
Copy link
Member

Actually, I've just pulled this locally and merged it in. Thanks, @dylanpilz!

@stephenfin stephenfin closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing show_default detection via context_settings.
3 participants