DOCSUP-3824: Documented the Regex and Raw formats #16790
Conversation
robot-clickhouse
added
pr-documentation
This reverts commit 5884b1e.
robot-clickhouse
removed
the
submodule changed
docs/en/interfaces/formats.md
Outdated
| @@ -1290,6 +1291,89 @@ $ cat filename.orc | clickhouse-client --query="INSERT INTO some_table FORMAT OR | |||
|
|
|||
| To exchange data with Hadoop, you can use [HDFS table engine](../engines/table-engines/integrations/hdfs.md). | |||
|
|
|||
| ## LineAsString {#lineasstring} | |||
|
|
|||
| In this format, a sequence of string objects separated by a newline character is interpreted as a single value. This format can only be parsed for table with a single field of type [String](../sql-reference/data-types/string.md). The remaining columns must be set to [DEFAULT](../sql-reference/statements/create/table.md#default) or [MATERIALIZED](../sql-reference/statements/create/table.md#materialized), or omitted. | |||
There was a problem hiding this comment.
I don't see newline chars in the example. Maybe we talk about any string sequence including strings terminated with newlines?
|
|
||
| **Usage** | ||
|
|
||
| The regular expression from `format_regexp` setting is applied to every line of imported data. The number of subpatterns in the regular expression must be equal to the number of columns in imported dataset. |
There was a problem hiding this comment.
It looks like the first sentence of the whole description must look like this one with lower details.
|
|
||
| The regular expression from `format_regexp` setting is applied to every line of imported data. The number of subpatterns in the regular expression must be equal to the number of columns in imported dataset. | ||
|
|
||
| Lines of the imported data must be separated by newline character `'\n'` or DOS-style newline `"\r\n"` (except the `Raw` format, which does not support any escaping characters). |
There was a problem hiding this comment.
except the
Rawformat, which does not support any escaping characters
It's not correct, Raw escaping rule doesn't affect the way lines should be separated at all. Just remove this part about Raw.
There was a problem hiding this comment.
@Avogar The problem is that I had to re-fork the repository since this PR was published, so I cannot reach the branch to update it. Will you, please, merge these changes into master, and I will immediately create a new branch with fixes?
There was a problem hiding this comment.
@olgarev I can't merge this PR because it has conflicts with current master and I can't resolve it because the repository with this branch doesn't exist anymore. So, you can create a new branch, copy changes from this PR, update them and make a new PR, after creating a new PR you can close this one and leave a link to the new one here.
|
@olgarev Hi! I figured out how to resolve conflicts and merge these changes. So, now you can add fixes. |
|
@Avogar Thank you! It looks like you've already done the necessary changes (removed the wrong phrase), so I need to do nothing. Thanks again ) |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category: