Allow nested with multiple nesting and subcolumns of complex types #17310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
doc-alert
pr-feature
This was referenced Nov 26, 2020
| String toString() const; | ||
| }; | ||
|
|
||
| struct SubstreamPath : public std::vector<Substream> |
| @@ -46,10 +48,13 @@ IMergeTreeDataPart::MergeTreeReaderPtr MergeTreeDataPartWide::getReader( | |||
| const ValueSizeMap & avg_value_size_hints, | |||
| const ReadBufferFromFileBase::ProfileCallback & profile_callback) const | |||
| { | |||
| auto new_settings = reader_settings; | |||
| new_settings.convert_nested_to_subcolumns = true; | |||
src/DataTypes/DataTypeArray.cpp
Outdated
| sizes_data.resize(offsets_data.size()); | ||
| sizes_data[0] = offsets_data[0]; | ||
| for (size_t i = 1; i < offsets_data.size(); ++i) | ||
| sizes_data[i] = offsets_data[i] - offsets_data[i - 1]; |
There was a problem hiding this comment.
I expect that compiler will generate suboptimal code due to possible aliasing.
src/DataTypes/DataTypeArray.cpp
Outdated
| offsets_data.resize(sizes_data.size()); | ||
| offsets_data[0] = sizes_data[0]; | ||
| for (size_t i = 0; i < sizes_data.size(); ++i) | ||
| offsets_data[i] = offsets_data[i - 1] + sizes_data[i]; |
There was a problem hiding this comment.
The same issue as above.
alexey-milovidov
approved these changes
Jan 16, 2021
|
Looks like conversion from ANTLR AST is wrong. I will disable this test for ANTLR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Data type
Nestednow supports arbitrary levels of nesting. Introduced subcolumns of complex types, such assize0inArray,nullinNullable, names ofTupleelements, which can be read without reading of whole column.Detailed description / Documentation draft:
Continuation of #14963.
This closes #18826.