Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSUP-6295: Updated isIPv4String and isIPv6String functions documentation #20085

Merged
merged 13 commits into from
Feb 13, 2021
Merged

DOCSUP-6295: Updated isIPv4String and isIPv6String functions documentation #20085

merged 13 commits into from
Feb 13, 2021

Conversation

gyuton
Copy link
Contributor

@gyuton gyuton commented Feb 4, 2021 •
edited

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

@robot-clickhouse robot-clickhouse added the pr-documentation Documentation PRs for the specific code PR label Feb 4, 2021
@gyuton
Merge branch 'master' of https://github.com/ClickHouse/ClickHouse int…
75c6bc9 
…o gyuton-DOCSUP-6295-Update_isIPv4String-andisIPv6String-functions
@gyuton gyuton marked this pull request as ready for review February 6, 2021 10:13
@abyss7 abyss7 self-assigned this Feb 9, 2021
gyuton and others added 3 commits February 12, 2021 09:21
@gyuton @olgarev
Update docs/ru/sql-reference/functions/ip-address-functions.md
275a787 
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
@gyuton @olgarev
Update docs/en/sql-reference/functions/ip-address-functions.md
5ef5903 
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
@gyuton
Fixes
90ba831
@gyuton
Copy link
Contributor Author

gyuton commented Feb 12, 2021

@vdimir , Hi!
Can you review this, please?

vdimir
vdimir approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only added more examples with different strings.

Thank you for you PR.

@vdimir vdimir self-assigned this Feb 12, 2021
@gyuton
Copy link
Contributor Author

gyuton commented Feb 12, 2021

I've only added more examples with different strings.

Thank you for you PR.

@vdimir, you're welcome!

@vdimir vdimir merged commit 3f7128d into ClickHouse:master Feb 13, 2021
@gyuton gyuton deleted the gyuton-DOCSUP-6295-Update_isIPv4String-andisIPv6String-functions branch June 10, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olgarev olgarev olgarev left review comments

@vdimir vdimir vdimir approved these changes

Assignees

@abyss7 abyss7

@vdimir vdimir

Labels
pr-documentation Documentation PRs for the specific code PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gyuton @vdimir @olgarev @abyss7 @robot-clickhouse