Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some CI-related scripts to github #20946

Merged
merged 24 commits into from
Mar 12, 2021
Merged

Move some CI-related scripts to github #20946

merged 24 commits into from
Mar 12, 2021

Conversation

tavplubix
Copy link
Member

@tavplubix tavplubix commented Feb 18, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Detailed description / Documentation draft:

  1. Now tests tasks can write results into test_results.tsv file and check status into check_status.tsv. The first file should contain two or three columns (test name, result (OK or FAIL) and test time), each row is a result of some test. The second file should contain one row with check status to show on github, the first column is a status (success for green tick or failure for red cross) and the second column is text description. Task can put any logs into /test_output/ dir. All files from /test_output/ will be uploaded to s3 and attached to the report.
  2. Part of integration tests runner moved from internal Yandex repository to GitHub
  3. Check for hung queries is enabled for stress tests.

https://nda.ya.ru/t/hXTUekXP3krdjb

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 18, 2021
@tavplubix
Copy link
Member Author

Stress test (address) - #21004
Stress test (thread) - something strange happened...

@tavplubix tavplubix added the force tests The label does nothing, NOOP, None, nil label Feb 22, 2021
@tavplubix
Copy link
Member Author

Stress test (memory) - ALTER TABLE mt_00763_1 MODIFY column s String; hung waiting for mutation

@tavplubix
Copy link
Member Author

d5ea345:
Stress test (address) - SYSTEM SYNC REPLICA hung waiting on StorageReplicatedMergeTree::waitForShrinkingQueueSize
Stress test (thread) - SYSTEM RELOAD DICTIONARIES hung inside LoadingDispatcher::loadImpl

@tavplubix
Copy link
Member Author

tavplubix commented Feb 23, 2021

Stress test (address) - ALTER TABLE mt_00763_1 MODIFY column s UInt32 hung waiting for mutation - StorageMergeTree::waitForMutation
Stress test (thread) - WATCH test.lv EVENTS - #21004
Stress test (undefined) - ALTER TABLE collapsing_00682 DELETE WHERE k IN (1, 2) and alter table lc_empty_part_bug modify column s LowCardinality(String); - merges were stopped

@tavplubix
Copy link
Member Author

tavplubix commented Feb 24, 2021

f41e68d:
Stress test (address) - alter table lc_empty_part_bug modify column s LowCardinality(String) - StorageMergeTree::waitForMutation
Stress test (thread) - SELECT 2, count() FROM system.numbers - bad test 00600_replace_running_query
Stress test (undefined) - 2021.02.24 01:17:42.862194 [ 3599 ] {3816e576-c98e-47e8-8ab7-105aeb6978a8} <Error> TCPHandler: Code: 49, e.displayText() = DB::Exception: The old table was not completely removed from ZooKeeper, /clickhouse/tables/test_00993/alter_table still exists and may contain some garbage. But it should never happen according to the logic of operations (it's a bug).

3632c1d:
Stress test (address) - ALTER TABLE replicated_mutation_table MODIFY COLUMN value UInt64 SETTINGS replication_alter_partitions_sync = 2 - hung waiting for mutation which was killed
Stress test (thread) - SELECT 2, count() FROM system.numbers

@tavplubix tavplubix changed the title Write stress test results into test_results.tsv Move some CI-related scripts to github Feb 24, 2021
@tavplubix
Copy link
Member Author

Stress test (thread) - OOM

import csv

OK_SIGN = 'OK ]'
FAILED_SIGN = 'FAILED ]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double whitespace.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it should be. Output of gtest looks like this:

[----------] 4 tests from ColumnUnique
[ RUN      ] ColumnUnique.InsertRange
[       OK ] ColumnUnique.InsertRange (5810 ms)
[ RUN      ] ColumnUnique.InsertRangeWithOverflow
../src/Columns/tests/gtest_column_unique.cpp:83: Failure
Expected equality of these values:
  idx->size()
    Which is: 1000000
  num_values + 1
    Which is: 1000001
[  FAILED  ] ColumnUnique.InsertRangeWithOverflow (5937 ms)

@tavplubix
Copy link
Member Author

Docs check - broken in master
Functional stateless tests flaky check - 00600_replace_running_query - looks unrelated, the test was bad before current changes
Integration tests (thread) - test_zookeeper_config/test.py::test_secure_connection - flaky

@tavplubix tavplubix merged commit e314112 into master Mar 12, 2021
@tavplubix tavplubix deleted the stress_test_results branch March 12, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force tests The label does nothing, NOOP, None, nil pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants