Constraints complex types support #20990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
pr-not-for-changelog
alexey-milovidov
requested changes
Feb 21, 2021
| { | ||
| UInt8 value = res_const->getValue<UInt64>(); | ||
| if (const auto * column_nullable = checkAndGetColumn<ColumnNullable>(*result_column)) | ||
| result_column = column_nullable->getNestedColumnPtr(); |
There was a problem hiding this comment.
There is an issue: if the value of Nullable column is NULL, the value of the nested column is undetermined and we cannot rely on it. Example: SELECT number % 2 AS n, nullIf(n, 1) AS nullable, assumeNotNull(nullable) AS unwrapped FROM numbers(10)
kitaisreal
force-pushed
the
constraints-complex-type-support
branch
from
f62092f
to
23af530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Fixes #20880.
Fixes #19334.
Changelog category (leave one):