[WIP] Porting to freebsd: initial, compile ok, most tests ok. #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
proller
commented
Dec 21, 2016
proller
commented
alexey-milovidov
approved these changes
Dec 24, 2016
| if (0 != prctl(PR_SET_NAME, name, 0, 0, 0)) | ||
| #else | ||
| #if defined(__FreeBSD__) | ||
| pthread_set_name_np(pthread_self(), name); |
There was a problem hiding this comment.
Result is not checked.
| @@ -133,7 +133,7 @@ class Allocator | |||
| */ | |||
| void * realloc(void * buf, size_t old_size, size_t new_size, size_t alignment = 0) | |||
| { | |||
| #ifndef __APPLE__ | |||
| #if !defined(__APPLE__) && !defined(__FreeBSD__) | |||
There was a problem hiding this comment.
FreeBSD has mremap (according to random internet page).
| double musl_exp10(double x); | ||
|
|
||
| #if defined(__FreeBSD__) | ||
| //const auto& exp10 = musl_exp10; // it must be the name of a function with external linkage |
There was a problem hiding this comment.
Please remove commented code if it is not needed.
lgbo-ustc
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Feb 8, 2023
Co-authored-by: shuai.li <shuai.li@kyligence.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.