AddDefaultDatabaseVisitor support dictGet #29650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
|
@kitaisreal can you fix build? |
|
@Avogar first need to refactor context. |
kitaisreal
force-pushed
the
add-default-database-visitor-support-dict-get
branch
from
459952b
to
c1f0445
Compare
|
@Avogar lets review it now. |
Avogar
approved these changes
Oct 14, 2021
|
Could some one compile deb package with the last ClickHouse stable version and this PR please? We can't migrate to a new cluster because of this bug. Thanks. |
|
I think it worth to backport it to 21.10, 21.9, 21.8 |
kitaisreal
added
the
pr-must-backport
This was referenced Oct 27, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 29, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 29, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 29, 2021
kitaisreal
added a commit
that referenced
this pull request
Oct 29, 2021
Backport #29650 to 21.10: AddDefaultDatabaseVisitor support dictGet
kitaisreal
added a commit
that referenced
this pull request
Oct 29, 2021
Backport #29650 to 21.8: AddDefaultDatabaseVisitor support dictGet
kitaisreal
added a commit
that referenced
this pull request
Oct 29, 2021
Backport #29650 to 21.9: AddDefaultDatabaseVisitor support dictGet
Felixoid
added
the
pr-backports-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Closes #29559.