Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix replaceRegexpAll bug #30292

Merged
merged 6 commits into from
Oct 19, 2021
Merged

fix replaceRegexpAll bug #30292

merged 6 commits into from
Oct 19, 2021

Conversation

Joeywzr
Copy link
Contributor

@Joeywzr Joeywzr commented Oct 16, 2021

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
fix replaceRegexpAll bug

Detailed description / Documentation draft:
#30245

By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.

If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Oct 16, 2021
@den-crane
Copy link
Contributor

den-crane commented Oct 16, 2021

I would add test for replaceRegexpAll as well. One day trim can be reworked without using Regex. Then your test will stop to check replaceRegexpAll.

@Joeywzr
Copy link
Contributor Author

Joeywzr commented Oct 16, 2021

I would add test for replaceRegexpAll as well. One day trim can be reworked with using Regex. Then your test will stop to check replaceRegexpAll.

OK.

@vdimir vdimir self-assigned this Oct 19, 2021
Copy link
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@vdimir vdimir merged commit 49685f0 into ClickHouse:master Oct 19, 2021
@alexey-milovidov
Copy link
Member

@vdimir

fix replaceRegexpAll bug

This is not a good changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants