Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSUP-14784: Document the system.session_log system table #30573

Conversation

sevirov
Copy link
Contributor

@sevirov sevirov commented Oct 22, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

Задокументировал системную таблицу session_log.
@robot-clickhouse robot-clickhouse added the pr-documentation Documentation PRs for the specific code PR label Oct 22, 2021
Внес маленькие правки.
sevirov and others added 8 commits October 24, 2021 14:50
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
Выполнил перевод на русский язык.
@sevirov
Copy link
Contributor Author

sevirov commented Oct 24, 2021

@vitlibar Please, review this PR.

@sevirov sevirov marked this pull request as ready for review October 24, 2021 18:06
@vitlibar vitlibar self-assigned this Oct 29, 2021
Contains information about all successful and failed login and logout events.

!!! note "Note"
User sessions are implicit and rely on the proper co-operation from context users.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean?

@vitlibar I agree with you. It will be unclear to the user as well. I deleted the note.

Удалил примечание.
- `LoginSuccess` — Successful login.
- `Logout` — Logout from the system.
- `session_id` ([UUID](../../sql-reference/data-types/uuid.md)) — Session id.
- `session_name` ([String](../../sql-reference/data-types/string.md)) — Session name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The columns session_id, session_name, and changed_settings have changed, see #30882

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitlibar Ok. I renamed the columns.

Переименовал столбцы.
- `LoginSuccess` — Successful login.
- `Logout` — Logout from the system.
- `auth_id` ([UUID](../../sql-reference/data-types/uuid.md)) — Session id.
- `session_id` ([String](../../sql-reference/data-types/string.md)) — Session name.
Copy link
Member

@vitlibar vitlibar Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong. auth_id is not the same as session_id, they're different things! Session ID is passed by client via HTTP interface. Please write that and also put here a link to the explanation in https://clickhouse.com/docs/en/interfaces/http/

auth_id is authentication ID, it's an UUID which is generated automatically each time a user logins.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong. auth_id is not the same as session_id, they're different things! Session ID is passed by client via HTTP interface. Please write that and also put here a link to the explanation in https://clickhouse.com/docs/en/interfaces/http/

auth_id is authentication ID, it's an UUID which is generated automatically each time a user logins.

@vitlibar Thank you. I fixed.

Поправил описание некоторых столбцов.
@vitlibar vitlibar merged commit ec983a6 into ClickHouse:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-documentation Documentation PRs for the specific code PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants