-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix case-insensetive search in UTF8 strings #30663
Conversation
aa480b9
to
a1cab43
Compare
Do I understand correctly that we just perform full comparison after found a candidate match, and before this PR it was something less trivial? PS. Do we have perf test for it? |
Yep
Not precisely, before this PR we just skipped first
ClickHouse/tests/performance/cpu_synthetic.xml Lines 38 to 40 in 990f8a2
|
Alright! I expect there will be no visible performance degradation. |
Integration tests were temporarily broken for a moment - ok. |
No difference in peft test. |
Backport #30663 to 21.9: Fix case-insensetive search in UTF8 strings
Backport #30663 to 21.8: Fix case-insensetive search in UTF8 strings
Backport #30663 to 21.10: Fix case-insensetive search in UTF8 strings
Backport #30663 to 21.3: Fix case-insensetive search in UTF8 strings
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Functions for case-insensitive search in UTF8 strings like
positionCaseInsensitiveUTF8
andcountSubstringsCaseInsensitiveUTF8
might find substrings that actually does not match, it's fixed.