Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSUP-14532: Support SETTINGS clause for S3 engine #30982

Conversation

olgarev
Copy link
Contributor

@olgarev olgarev commented Nov 2, 2021

Changelog category (leave one):

@robot-clickhouse robot-clickhouse added the pr-documentation Documentation PRs for the specific code PR label Nov 2, 2021
@olgarev olgarev changed the title DOCSUP-14532: Settings in query support for the S3 table engine DOCSUP-14532: Support SETTINGS clause for S3 engine Nov 2, 2021
@olgarev olgarev marked this pull request as ready for review November 7, 2021 13:40
@olgarev
Copy link
Contributor Author

olgarev commented Nov 7, 2021

@nikitamikhaylov Hi, could you review this PR please? (mind my previous questions in Telegram also)

INSERT INTO s3_engine_table VALUES ('one', 1), ('two', 2), ('three', 3);
```

3. Выберите данные:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this separation is not needed, because I don't like how Выберите данные sounds in Russian.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikitamikhaylov I modified the examples, please see now.

@nikitamikhaylov nikitamikhaylov merged commit 1cd1677 into ClickHouse:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-documentation Documentation PRs for the specific code PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants