-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional hdfs url check #31042
Conversation
Backport #31042 to 21.9: Add additional hdfs url check
Backport #31042 to 21.11: Add additional hdfs url check
Backport #31042 to 21.10: Add additional hdfs url check
Backport #31042 to 21.8: Add additional hdfs url check
@Avogar, @kssenii - by adding hdfs uri check a bug for valid hdfs uri's using HA namenode address is introduced. Currently used regex requires each uri to include ":portnumber" which in case of HA namenode address + hdfs-site.xml config is not required/doesn't work. Would you like me to open a bug report on the same? The issue is introduced in this commit + currently only present in 21.11.x release. |
Hi! Thanks for reporting it, I will fix it this week. No need to open an issue. |
I have also encountered this issue, the exception: Code: 36. DB::Exception: Received from localhost:9000. DB::Exception: Bad hdfs url: hdfs://hdfs@nameservice1/user/admin/name.csv. It should have structure 'hdfs://<host_name>:<port>/<path>'. (BAD_ARGUMENTS) ClickHouse 21.11.2.2 didn't merge this commit, I temporarily use this version. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix abort in debug server and
DB::Exception: std::out_of_range: basic_string
error in release server in case of bad hdfs url by adding additional check of hdfs url structure.Detailed description / Documentation draft:
Such query let to abort in debug server and
DB::Exception: std::out_of_range: basic_string
error in release server: