-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lambda for approve #31139
Add lambda for approve #31139
Conversation
tests/ci/approve_lambda/app.py
Outdated
"s-mx", # Maxim Sabyanin, former employee, present contributor | ||
"sevirov", # technical writer, Yandex | ||
"spongedu", # Seasoned contributor | ||
"ucasFL", # Amos Bird's friend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed my name to lower case: ucasfl
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe check here can be case-insensitive? GitHub redirects usernames that differs only with case to default one, so I suppose it's impossible to have different users for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, what is the purpose of the PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe check here can be case-insensitive? GitHub redirects usernames that differs only with case to default one, so I suppose it's impossible to have different users for them.
Yes, it's case-insensitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> Btw, what is the purpose of the PR :)
Automatically approve github actions run.
Changelog category (leave one):