Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lambda for approve #31139

Merged
merged 6 commits into from
Nov 8, 2021
Merged

Add lambda for approve #31139

merged 6 commits into from
Nov 8, 2021

Conversation

alesapin
Copy link
Member

@alesapin alesapin commented Nov 8, 2021

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 8, 2021
tests/ci/approve_lambda/app.py Outdated Show resolved Hide resolved
tests/ci/approve_lambda/app.py Outdated Show resolved Hide resolved
"s-mx", # Maxim Sabyanin, former employee, present contributor
"sevirov", # technical writer, Yandex
"spongedu", # Seasoned contributor
"ucasFL", # Amos Bird's friend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed my name to lower case: ucasfl :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check here can be case-insensitive? GitHub redirects usernames that differs only with case to default one, so I suppose it's impossible to have different users for them.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, what is the purpose of the PR :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check here can be case-insensitive? GitHub redirects usernames that differs only with case to default one, so I suppose it's impossible to have different users for them.

Yes, it's case-insensitive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> Btw, what is the purpose of the PR :)
Automatically approve github actions run.

@alesapin alesapin merged commit 8566252 into master Nov 8, 2021
@alesapin alesapin deleted the approve_lambda branch November 8, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants