-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in Keeper when some logs was lost #31150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Nov 8, 2021
alesapin
added
jepsen-test
Need to test this PR with jepsen tests
and removed
pr-bugfix
Pull request with bugfix, not backported by default
labels
Nov 8, 2021
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Nov 8, 2021
novikd
approved these changes
Nov 8, 2021
No related failures. |
This was referenced Nov 9, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 10, 2021
And we can have uncommitted data in snapshot? Or how does it work? |
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 10, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 10, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 10, 2021
alesapin
added a commit
that referenced
this pull request
Nov 11, 2021
Backport #31150 to 21.11: Fix bug in Keeper when some logs was lost
alesapin
added a commit
that referenced
this pull request
Nov 15, 2021
Backport #31150 to 21.9: Fix bug in Keeper when some logs was lost
alesapin
added a commit
that referenced
this pull request
Nov 15, 2021
Backport #31150 to 21.10: Fix bug in Keeper when some logs was lost
alexey-milovidov
added a commit
that referenced
this pull request
Nov 24, 2021
Backport #31150 to 21.8: Fix bug in Keeper when some logs was lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
jepsen-test
Need to test this PR with jepsen tests
pr-bugfix
Pull request with bugfix, not backported by default
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug in Keeper which can lead to inability to start when some coordination logs was lost and we have more fresh snapshot than our latest log.