Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Keeper when some logs was lost #31150

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Conversation

alesapin
Copy link
Member

@alesapin alesapin commented Nov 8, 2021

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug in Keeper which can lead to inability to start when some coordination logs was lost and we have more fresh snapshot than our latest log.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 8, 2021
@alesapin alesapin added jepsen-test Need to test this PR with jepsen tests and removed pr-bugfix Pull request with bugfix, not backported by default labels Nov 8, 2021
@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 8, 2021
@novikd novikd self-assigned this Nov 8, 2021
@alesapin
Copy link
Member Author

alesapin commented Nov 9, 2021

No related failures.

@qoega
Copy link
Member

qoega commented Nov 10, 2021

And we can have uncommitted data in snapshot? Or how does it work?

alesapin added a commit that referenced this pull request Nov 15, 2021
Backport #31150 to 21.9: Fix bug in Keeper when some logs was lost
alesapin added a commit that referenced this pull request Nov 15, 2021
Backport #31150 to 21.10: Fix bug in Keeper when some logs was lost
alexey-milovidov added a commit that referenced this pull request Nov 24, 2021
Backport #31150 to 21.8: Fix bug in Keeper when some logs was lost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jepsen-test Need to test this PR with jepsen tests pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants