Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SHOW GRANTS when partial revokes are used. #31249

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

vitlibar
Copy link
Member

Changelog category:

  • Bug Fix

Changelog entry:
Fix SHOW GRANTS when partial revokes are used. This PR fixes #31138

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 10, 2021
@Avogar
Copy link
Member

Avogar commented Nov 12, 2021

@vitlibar Can you look at failed Functional stateless tests flaky check?

@vitlibar
Copy link
Member Author

vitlibar commented Nov 12, 2021

@vitlibar Can you look at failed Functional stateless tests flaky check?

It failed because the test creates some user (named test_user_01073) and the flaky check runs multiple instances of the test in multiple threads in parallel, so for the second run the user already exists and thus all those runs except the first one fail. I think we can just ignore that, it must not become a problem in master.

@Avogar Avogar merged commit 051a9e7 into ClickHouse:master Nov 12, 2021
Avogar added a commit that referenced this pull request Nov 15, 2021
Backport #31249 to 21.9: Fix SHOW GRANTS when partial revokes are used.
Avogar added a commit that referenced this pull request Nov 15, 2021
Backport #31249 to 21.11: Fix SHOW GRANTS when partial revokes are used.
Avogar added a commit that referenced this pull request Nov 15, 2021
Backport #31249 to 21.10: Fix SHOW GRANTS when partial revokes are used.
Avogar added a commit that referenced this pull request Nov 15, 2021
Backport #31249 to 21.8: Fix SHOW GRANTS when partial revokes are used.
@vitlibar vitlibar deleted the fix-show-grants branch November 17, 2021 15:35
vitlibar pushed a commit that referenced this pull request Nov 17, 2021
Fix SHOW GRANTS when partial revokes are used.

(cherry picked from commit 051a9e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REVOKE SELECT on another table alters order of applying GRANTS
3 participants