-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for DatabaseOrdinary in MaterializedMySQL #31292
Drop support for DatabaseOrdinary in MaterializedMySQL #31292
Conversation
3068f01
to
dcd444c
Compare
5640ede
to
386b822
Compare
8ffb46b
to
11222fb
Compare
Unrelated failures: Related failures: |
11222fb
to
1011fd8
Compare
|
Yes, I'll look at it today. |
1. Dropped support for DatabaseOrdinary for MaterializeMySQL. It is marked as experimental, and dropping support makes the code more maintaible, and speeds up integration tests by 50%. 2. Get rid of thread name logic for StorageMaterializeMySQL wrapping, use setInternalQuery instead (similar to MaterializedPostgreSQL).
and print instructions on how to remove and recreate.
1011fd8
to
b91f21d
Compare
@tavplubix looking at the remaining test failures: "Fast test" seems to fail because the Raft port is already taken (could be a recent process exiting uncleanly?) "Stress test (thread, actions)" has a failing test script, but I can't make out why from the logs. Any ideas @tavplubix ? |
Tests failures are unrelated to changes |
The default database engine has been "Atomic" since ClickHouse 20.10. To improve maintainability of the experimental MaterializedMySQL feature, this PR drops support for the "Ordinary" engine for backing MaterializedMySQL.
Also get rid of thread name logic for StorageMaterializeMySQL wrapping, use setInternalQuery instead (similar to MaterializedPostgreSQL).
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Drop support for using Ordinary databases with MaterializedMySQL
Detailed description / Documentation draft: