Fix cleanup in integration tests #31605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
vitlibar
commented
Nov 21, 2021
| # https://stackoverflow.com/questions/48767760/how-to-make-docker-container-ls-f-name-filter-by-exact-name | ||
| filter_name = f'^/{self.project_name}_.*_1$' | ||
| # We want the command "docker container list" to show only containers' ID and their names, separated by colon. | ||
| format = '{{.ID}}:{{.Names}}' |
There was a problem hiding this comment.
Docker has changed the default format of the output of docker container list. In earlier versions this commands showed only IDs of the running containers, but currently by default it shows a table with the following header:
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
So now we have to specify the format in the explicit way. '{{.ID}}:{{.Names}}' means we want to see only containers' ID and names, separated by colon.
|
@Mergifyio update |
✅ Branch has been successfully updated |
alesapin
approved these changes
Nov 22, 2021
vitlibar
force-pushed
the
fix-cleanup-in-integration-tests
branch
from
cbf65df
to
6f5f727
Compare
|
Works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category:
Fix cleanup in integration tests.
This PR fixes some flaky tests, for example
test_part_moves_between_shards/, which sometimes suddenly failed with the errorNo such container.