Fix segfault on attach parititon #31738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
tavplubix
force-pushed
the
fix_segfault_on_attach_partition
branch
from
ad7fe45
to
1ab8b5d
Compare
| { | ||
| String old_name; | ||
| String new_name; | ||
| DiskPtr disk; |
There was a problem hiding this comment.
As I can guess, both old and new part should be on the same disk?
Maybe add a comment here ...
Comment on lines
36
to
37
| export -f thread_detach_attach; | ||
| export -f thread_detach_attach; |
Comment on lines
42
to
44
| timeout $TIMEOUT bash -c thread_detach_attach 2> /dev/null & | ||
| timeout $TIMEOUT bash -c thread_detach_attach 2> /dev/null & | ||
| timeout $TIMEOUT bash -c thread_detach_attach 2> /dev/null & |
There was a problem hiding this comment.
thread_drop_detached somewhere?
KochetovNicolai
approved these changes
Nov 29, 2021
tavplubix
force-pushed
the
fix_segfault_on_attach_partition
branch
from
9d94b5a
to
2cf4b51
Compare
This was referenced Nov 30, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 30, 2021
tavplubix
added a commit
that referenced
this pull request
Dec 1, 2021
Backport #31738 to 21.11: Fix segfault on attach parititon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed rare segfault on concurrent
ATTACH PARTITIONqueries.Detailed description / Documentation draft:
Also removed some bad code
https://clickhouse-test-reports.s3.yandex.net/30599/200913a5a575ffb03a0307c68da4162c9844acbb/stress_test_(address).html#fail1