Fix usage of Buffer table engine with type Map
#31742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
approved these changes
Nov 24, 2021
This was referenced Nov 25, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 25, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 25, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 25, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 25, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 25, 2021
CurtizJ
added a commit
that referenced
this pull request
Nov 25, 2021
Backport #31742 to 21.9: Fix usage of `Buffer` table engine with type `Map`
CurtizJ
added a commit
that referenced
this pull request
Nov 25, 2021
Backport #31742 to 21.11: Fix usage of `Buffer` table engine with type `Map`
CurtizJ
added a commit
that referenced
this pull request
Nov 25, 2021
Backport #31742 to 21.8: Fix usage of `Buffer` table engine with type `Map`
CurtizJ
added a commit
that referenced
this pull request
Nov 25, 2021
Backport #31742 to 21.10: Fix usage of `Buffer` table engine with type `Map`
CurtizJ
added a commit
that referenced
this pull request
Nov 27, 2021
Backport #31742 to 21.3: Fix usage of `Buffer` table engine with type `Map`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix usage of
Buffertable engine with typeMap.Fixes #30546.
Detailed description / Documentation draft:
The bug was in mutation of
ColumnMap, which is implemented via methodforEachSubcolumn. Nested column was not copied and data race could appear.