Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with empty result on odbc query #31766

Merged
merged 8 commits into from
Dec 1, 2021
Merged

Conversation

kssenii
Copy link
Member

@kssenii kssenii commented Nov 25, 2021

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix crash with empty result on odbc query. Closes #31465.

Previously this query resulted in a crashed clickhouse:

kssenii > isql "ClickHouse DSN (ANSI)"  -v 
SQL> select 1 except select 1
SQLRowCount returns 0

with odbc parameter Url = https://localhost:8123/query?database=default&max_result_bytes=4000000&buffer_size=3000000
Now ok.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 25, 2021
@Avogar Avogar self-assigned this Nov 29, 2021
@Avogar
Copy link
Member

Avogar commented Nov 29, 2021

Can we write a test for it?

@kssenii kssenii merged commit 563b615 into ClickHouse:master Dec 1, 2021
kssenii added a commit that referenced this pull request Dec 3, 2021
Backport #31766 to 21.8: Fix crash with empty result on odbc query
alexey-milovidov added a commit that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odbc query Segmentation fault (11) and crash clickhouse server
3 participants