-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse partition key value from partition_id
when need to create part in empty partition
#31887
Conversation
5e0f094
to
2fb0017
Compare
Integration tests - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I didn't understand why do we need changes in MergeTreeData::getPartitionIDFromQuery
.
Changes in |
Integration tests flaky check (asan) — Failed to read test_results.tsv, cc: @alesapin |
…d` when need to create part in empty partition
…` when need to create part in empty partition
…d` when need to create part in empty partition
Backport #31887 to 21.11: Parse partition key value from `partition_id` when need to create part in empty partition
Backport #31887 to 21.9: Parse partition key value from `partition_id` when need to create part in empty partition
…` when need to create part in empty partition
Backport #31887 to 21.8: Parse partition key value from `partition_id` when need to create part in empty partition
Backport #31887 to 21.10: Parse partition key value from `partition_id` when need to create part in empty partition
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Some
GET_PART
entry might hang in replication queue if part is lost on all replicas and there are no other parts in the same partition. It's fixed in cases when partition key contains only columns of integer types orDate[Time]
. Fixes #31485.