Fix FileLog engine unnesessary create meta data directory when create table failed #31967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
kssenii
approved these changes
Nov 30, 2021
| @@ -0,0 +1,3 @@ | |||
| CREATE TABLE log (A String) ENGINE= FileLog('/tmp/aaa.csv', 'CSV'); -- {serverError 36 } | |||
| CREATE TABLE log (A String) ENGINE= FileLog('/tmp/aaa.csv', 'CSV'); -- {serverError 36 } | |||
| CREATE TABLE log (A String) ENGINE= FileLog('/tmp/aaa.csv', 'CSV'); -- {serverError 36 } | |||
There was a problem hiding this comment.
May be in this test after creating file log engine with incorrect path, test creating with correct path (so it would be same as in the issue)?
There was a problem hiding this comment.
If creating with correct path after creating with incorrect path, it will success.
There was a problem hiding this comment.
I believe. Ok I see that is not easy to add such test because in will have to be .sh test and .sh test does not allow test hints to suppress expected error. Then ok as it is now.
There was a problem hiding this comment.
Hm, no, actually it is ok to add one more sh test.
(I believe that it works, but it might get broken in the future again)
… table failed. fix style
This was referenced Nov 30, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Nov 30, 2021
…data directory when create table failed
alexey-milovidov
added a commit
that referenced
this pull request
Dec 1, 2021
Backport #31967 to 21.11: Fix FileLog engine unnesessary create meta data directory when create table failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix FileLog engine unnesessary create meta data directory when create table failed. Fix #31962.