-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LeaderElection #32140
Merged
Merged
Remove LeaderElection #32140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-backward-incompatible
Pull request with backwards incompatible changes
label
Dec 2, 2021
Depends on #32157 |
tavplubix
force-pushed
the
remove_leader_election
branch
from
December 3, 2021 09:45
041e80d
to
29fab36
Compare
novikd
approved these changes
Dec 7, 2021
Merged
tavplubix
added a commit
that referenced
this pull request
Dec 8, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 9, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 9, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 9, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 9, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 9, 2021
Merged
tavplubix
added a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
A "leader election" mechanism is removed from
ReplicatedMergeTree
, because multiple leaders are supported since 20.6. If you are upgrading from older version and some replica with old version is a leader, then server will fail to start after upgrade. Stop replicas with old version to make new version start. After that it will not be possible to downgrade to version older than 20.6