Fix active replicas count in quorum inserts #32157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
tavplubix
added
the
pr-must-backport
Merged
tavplubix
force-pushed
the
fix_active_replicas_count_quorum
branch
from
14757c2
to
252192b
Compare
| replicas_status_futures.reserve(replicas.size()); | ||
| for (const auto & replica : replicas) | ||
| if (replica != storage.replica_name) | ||
| replicas_status_futures.emplace_back(zookeeper->asyncExists(fs::path(storage.zookeeper_path) / "replicas" / replica)); |
There was a problem hiding this comment.
Looks like it's just about existing replicas, not necessary active.
alexey-milovidov
approved these changes
Dec 2, 2021
This was referenced Dec 3, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 3, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 3, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 3, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 3, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 3, 2021
tavplubix
added a commit
that referenced
this pull request
Dec 5, 2021
Backport #32157 to 21.11: Fix active replicas count in quorum inserts
tavplubix
added a commit
that referenced
this pull request
Dec 5, 2021
Backport #32157 to 21.10: Fix active replicas count in quorum inserts
tavplubix
added a commit
that referenced
this pull request
Dec 5, 2021
Backport #32157 to 21.9: Fix active replicas count in quorum inserts
tavplubix
added a commit
that referenced
this pull request
Dec 5, 2021
Backport #32157 to 21.8: Fix active replicas count in quorum inserts
tavplubix
added a commit
that referenced
this pull request
Dec 5, 2021
Backport #32157 to 21.3: Fix active replicas count in quorum inserts
Felixoid
added
the
pr-backports-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Number of active replicas might be determined incorrectly when inserting with quorum if setting
replicated_can_become_leaderis disabled on some replicas. It's fixed.