Fix arraySlice with null args. #32456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
KochetovNicolai
added
the
pr-must-backport
| @@ -102,7 +102,7 @@ class FunctionArraySlice : public IFunction | |||
| { | |||
| if (!length_column || length_column->onlyNull()) | |||
| { | |||
| return array_column; | |||
| return arguments[0].column; | |||
There was a problem hiding this comment.
Ok. This avoids extracting the contents of the const column.
alexey-milovidov
approved these changes
Dec 9, 2021
This was referenced Dec 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 12, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 12, 2021
KochetovNicolai
added a commit
that referenced
this pull request
Dec 13, 2021
Backport #32456 to 21.3: Fix arraySlice with null args.
KochetovNicolai
added a commit
that referenced
this pull request
Dec 13, 2021
Backport #32456 to 21.12: Fix arraySlice with null args.
KochetovNicolai
added a commit
that referenced
this pull request
Dec 13, 2021
Backport #32456 to 21.11: Fix arraySlice with null args.
KochetovNicolai
added a commit
that referenced
this pull request
Dec 13, 2021
Backport #32456 to 21.10: Fix arraySlice with null args.
KochetovNicolai
added a commit
that referenced
this pull request
Dec 13, 2021
Backport #32456 to 21.9: Fix arraySlice with null args.
KochetovNicolai
added a commit
that referenced
this pull request
Dec 13, 2021
Backport #32456 to 21.8: Fix arraySlice with null args.
Felixoid
added
the
pr-backports-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fixes #29890