Fix test_prometheus_endpoint #32476
Merged
Fix test_prometheus_endpoint #32476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
| @@ -30,7 +30,7 @@ def parse_response_line(line): | |||
|
|
|||
| if line.startswith("#"): | |||
| return {} | |||
| match = re.match('^([a-zA-Z_:][a-zA-Z0-9_:]+)(\{.*\})? (\d)', line) | |||
| match = re.match('^([a-zA-Z_:][a-zA-Z0-9_:]+)(\{.*\})? -?(\d)', line) | |||
There was a problem hiding this comment.
Ok. This is for negative numbers.
alexey-milovidov
approved these changes
Dec 9, 2021
|
@Mergifyio rebase |
alexey-milovidov
force-pushed
the
fix_test_prometheus_endpoint
branch
from
77c95af
to
59cc3e4
Compare
✅ Branch has been successfully rebased |
vdimir
force-pushed
the
fix_test_prometheus_endpoint
branch
from
59cc3e4
to
a0488d2
Compare
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 22, 2022
(cherry picked from commit 6b0e6dd)
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 22, 2022
(cherry picked from commit 6b0e6dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Detailed description / Documentation draft:
...