Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename window-view function to time window function #32498

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

Vxider
Copy link
Contributor

@Vxider Vxider commented Dec 10, 2021

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

This PR renaming window-view function to time window function because window-view functions are used to aggregate data by time. The naming away from the window view also means that the window-view function does not need to be used with the window view.

e.g. use tumble function in a table for batch processing (SELECT * FROM * GROUP BY tumble(). (But it is meaningless to use the hop function without the window view)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 10, 2021
@kssenii kssenii added the can be tested Allows running workflows for external contributors label Dec 10, 2021
@kssenii kssenii self-assigned this Dec 10, 2021
@Vxider
Copy link
Contributor Author

Vxider commented Dec 10, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2021

update

☑️ Nothing to do

  • -closed [:pushpin: update requirement]
  • #commits-behind>0 [:pushpin: update requirement]

@kssenii kssenii merged commit 1865e37 into ClickHouse:master Dec 10, 2021
@Vxider Vxider deleted the rename-window-view-functions branch December 11, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants