[RFC] Update jemalloc to 5.3RC #33057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
No significant changes in jemalloc related metrics. |
azat
changed the title
azat
force-pushed
the
jemalloc-dev-branch
branch
from
7ffaa19
to
d72b110
Compare
azat
force-pushed
the
jemalloc-dev-branch
branch
3 times, most recently
from
6482a1c
to
19216f4
Compare
azat
force-pushed
the
jemalloc-dev-branch
branch
3 times, most recently
from
b9fafb7
to
6788f3f
Compare
|
@mergify update |
✅ Branch has been successfully updatedHey, I reacted but my real name is @Mergifyio |
azat
force-pushed
the
jemalloc-dev-branch
branch
from
c43709a
to
c69ac2e
Compare
And now we can use upstream jemalloc, since all required patches had been merged into upstream (we have to use fork since there was no new 5.2.x releases). v2: rebase to include patch for failed assert
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: update jemalloc one more time v3: - do not include jemalloc_mangle*.h - do not change jemalloc.h - fix for JEMALLOC_NOTHROW/JEMALLOC_SYS_NOTHROW Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: update jemalloc Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Those were just copied from include_linux_x86_64, and replaced x86_64 with the arch. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
- remove GNU_SOURCE it is done in common CMakeLists.txt - remove JEMALLOC_OVERRIDE___POSIX_MEMALIGN (there is no need to since __posix_memalign() does not exists in linux) Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Note, that there is no need to disable JEMALLOC_PURGE_MADVISE_FREE, since jemalloc does check in runtime, and ClickHouse already successfully works w/o this change. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: define JEMALLOC_DEFINE_MADVISE_FREE
https://s3.amazonaws.com/clickhouse-builds/33057/6482a1c48f22d80f704bf869857091045a3f6917/binary_ppc64le/build_log.log
v3: fix pthread_atfork
https://github.com/ClickHouse/ClickHouse/runs/5128801105?check_suite_focus=true
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
f
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Generated on osx 10.14 Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
…ilds Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
azat
force-pushed
the
jemalloc-dev-branch
branch
from
c69ac2e
to
6a2abd3
Compare
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
|
All issues seems to be resolved. @alexey-milovidov what do you think about upgrading jemalloc to 5.3RC? |
You mean: "No more custom patches for jemalloc, pure upstream" |
|
I don't like that "Performance Comparison" has errors. We need to fix all of them. |
|
@kitaisreal will fix "Performance Comparison" |
Right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Use new jemalloc 5.3RC release
Details:
Refs:
Checklist:
bin->low_bits_full > bin->low_bits_empty