-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add h3 misc functions - part 1 #33479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider to cast argument column to function return type, to avoid virtual calls.
What's the purpose of adding Let's either remove these functions |
@alexey-milovidov I guess I am fine to do either one of these:
Probably adding DEGREES and RADIANS could be a better way ? If we end up removing |
Yes, let's do it! |
Great, I will work on adding those funcs next. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add new h3 miscellaneous functions:
h3DegsToRads
,h3RadsToDegs
,h3HexAreaKm2
,h3CellAreaM2
,h3CellAreaRads2
.Detailed description / Documentation draft:
Add new h3 miscellaneous functions:
h3DegsToRads
,h3RadsToDegs
,h3HexAreaKm2
,h3CellAreaM2
,h3CellAreaRads2
as per: https://h3geo.org/docs/api/misc/Splitting up adding the functions into smaller PRs so that it's easy to review - will add the remaining misc functions separate PRs.
Related to #17708.