Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in indexes of not presented columns in -WithNames formats #35803

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

Avogar
Copy link
Member

@Avogar Avogar commented Mar 31, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug in indexes of not presented columns in -WithNames formats that led to error INCORRECT_NUMBER_OF_COLUMNS when the number of columns is more than 256. Closes #35793

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Mar 31, 2022
@CurtizJ CurtizJ self-assigned this Mar 31, 2022
@CurtizJ CurtizJ merged commit 075bcf3 into ClickHouse:master Apr 1, 2022
@manokonov
Copy link

hi! when is it planned to release these changes in lts version?

@CurtizJ
Copy link
Member

CurtizJ commented May 12, 2022

Let's backport this bugfix. Then a new release will be made in a few days.

@CurtizJ CurtizJ added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label May 12, 2022
robot-clickhouse pushed a commit that referenced this pull request May 12, 2022
robot-clickhouse pushed a commit that referenced this pull request May 12, 2022
Avogar added a commit that referenced this pull request May 13, 2022
Backport #35803 to 22.2: Fix bug in indexes of not presented columns in -WithNames formats
Avogar added a commit that referenced this pull request May 13, 2022
Backport #35803 to 22.3: Fix bug in indexes of not presented columns in -WithNames formats
kaynewu added a commit to kaynewu/ClickHouse that referenced this pull request Jun 9, 2022
* Backport ClickHouse#36167 to 22.3: Fix broken aliases during parsing of special operators

* Backport git fix for /build directory

* Trigger CI

* Update version to 22.3.5.20

* Backport ClickHouse#36637 to 22.3: Fix merges of wide parts with type `Object`

* Backport ClickHouse#36487 to 22.3: Add passphrase for certificates

* Backport ClickHouse#36707 to 22.3: Fix vertical merges in wide parts

* Update version to 22.3.6.5

* Backport ClickHouse#36910 to 22.3: Fix bug in keeper which could lead to corrupted compressed logs

* Update version to 22.3.7.5

* Backport ClickHouse#36866 to 22.3: Integration tests

* Backport ClickHouse#35803 to 22.3: Fix bug in indexes of not presented columns in -WithNames formats

* Backport ClickHouse#37021 to 22.3: Fixed problem with infs in `quantileTDigest`

* Backport ClickHouse#36463 to 22.3: Ignore DNS errors when checking if dictionary source is local

* Backport ClickHouse#37443 to 22.3: Functions normalize utf8 fix

* Backport ClickHouse#37336 to 22.3: Fix clash of constant strings in aggregate function, prewhere and join

* Backport ClickHouse#37690 to 22.3: Fix segfault with mysql db + show create table + named collections

Co-authored-by: robot-clickhouse <robot-clickhouse@clickhouse.com>
Co-authored-by: Mikhail f. Shiryaev <felixoid@clickhouse.com>
Co-authored-by: Anton Popov <ap@clickhouse.com>
Co-authored-by: Maksim Kita <maksim@clickhouse.com>
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
Co-authored-by: alesapin <alesapin@clickhouse.com>
Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
Co-authored-by: Vladimir C <vdimir@clickhouse.com>
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSVWithNames input format does not work properly when the target table has more than 256 columns
5 participants