Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid projections if INTERPOLATE with expressions is present #36549

Merged
merged 3 commits into from
Apr 25, 2022
Merged

Avoid projections if INTERPOLATE with expressions is present #36549

merged 3 commits into from
Apr 25, 2022

Conversation

yakov-olkhovskiy
Copy link
Member

@yakov-olkhovskiy yakov-olkhovskiy commented Apr 22, 2022 •
edited by KochetovNicolai

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix Missing column exception which could happen while using INTERPOLATE with ENGINE = MergeTree table.

closes #36530

@yakov-olkhovskiy yakov-olkhovskiy added pr-bugfix Pull request with bugfix, not backported by default can be tested Allows running workflows for external contributors labels Apr 22, 2022
KochetovNicolai
KochetovNicolai approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@KochetovNicolai KochetovNicolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is needed

@KochetovNicolai KochetovNicolai self-assigned this Apr 22, 2022
amosbird
amosbird reviewed Apr 24, 2022
View reviewed changes
tests/queries/0_stateless/02233_interpolate_1.sql Outdated
CREATE TABLE t_inter_02233 (n Int32) ENGINE = MergeTree ORDER BY n;
INSERT INTO t_inter_02233 VALUES (1),(3),(3),(6),(6),(6);
SELECT n, count() AS m FROM t_inter_02233 GROUP BY n ORDER BY n WITH FILL INTERPOLATE ( m AS m + 1 );
DROP TABLE IF EXISTS t_inter_02233;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

@KochetovNicolai
Copy link
Member

#36611

@KochetovNicolai KochetovNicolai added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Apr 25, 2022
@KochetovNicolai KochetovNicolai merged commit 0fa63a8 into master Apr 25, 2022
@KochetovNicolai KochetovNicolai deleted the interpolate-alias-fix branch April 25, 2022 11:18
This was referenced Apr 25, 2022
Merged
Closed
Closed
Closed
robot-clickhouse pushed a commit that referenced this pull request Apr 25, 2022
Backport #36549 to 22.4: Avoid projections if INTERPOLATE with expres…
c15c1e4 
…sions is present
@robot-clickhouse robot-clickhouse mentioned this pull request Apr 25, 2022
Merged
KochetovNicolai added a commit that referenced this pull request May 3, 2022
@KochetovNicolai
Merge pull request #36635 from ClickHouse/backport/22.4/36549
d5278cf 
Backport #36549 to 22.4: Avoid projections if INTERPOLATE with expressions is present
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
@amosbird amosbird mentioned this pull request Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amosbird amosbird amosbird left review comments

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels
can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

INTERPOLATE doesn't work for MergeTree
4 participants
@yakov-olkhovskiy @KochetovNicolai @amosbird @Felixoid