Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of datetime64 parsed from string '1969-12-31 23:59:59.123' #37039

Merged
merged 8 commits into from
May 24, 2022

Conversation

taiyang-li
Copy link
Contributor

@taiyang-li taiyang-li commented May 9, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix bug datetime64 parse from string '1969-12-31 23:59:59.123'. Close #36994

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label May 9, 2022
@nickitat nickitat self-assigned this May 9, 2022
@taiyang-li taiyang-li changed the title Fix bug datetime64 parse from string '1969-12-31 23:59:59.123' Fix bug of datetime64 parsed from string '1969-12-31 23:59:59.123' May 9, 2022
@taiyang-li
Copy link
Contributor Author

Failed fast tests had been fixed.

@taiyang-li
Copy link
Contributor Author

Failed tests not related to this pr.

Copy link
Member

@nickitat nickitat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not reviewing for so long

@nickitat nickitat merged commit e33cfc8 into ClickHouse:master May 24, 2022
@taiyang-li
Copy link
Contributor Author

@nickitat It's ok. Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClickHouse 22.4 does not handle DateTime64 correctly
3 participants