Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to kill empty list of containers in integration/runner II #38269

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

excitoon
Copy link
Contributor

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Also fixed an issue appeared in #37854

@tavplubix

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 21, 2022
@excitoon
Copy link
Contributor Author

excitoon commented Jun 21, 2022

@tavplubix The container sometimes did shutdown by itself between the pipe commands.

@tavplubix tavplubix self-assigned this Jun 21, 2022
@tavplubix tavplubix marked this pull request as draft June 27, 2022 12:15
@excitoon excitoon marked this pull request as ready for review June 27, 2022 20:14
@excitoon excitoon requested a review from tavplubix June 27, 2022 20:14
@tavplubix tavplubix merged commit e23f1fa into ClickHouse:master Jun 28, 2022
@excitoon
Copy link
Contributor Author

@tavplubix Cool!

Felixoid added a commit that referenced this pull request Jul 4, 2022
Felixoid added a commit that referenced this pull request Jul 4, 2022
Felixoid added a commit that referenced this pull request Jul 4, 2022
Felixoid added a commit that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants