Fix parts removal after incorrect server shutdown #38486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
robot-ch-test-poll2
added
the
pr-bugfix
Before this patch, and after transaction support had been added ClickHouse#24258, if the server had not removed old parts on shutdown, then they will left forever. Fixes: ClickHouse#24258 (cc @tavplubix) v2: use Tx::PrehistoricTID over removePartsFromWorkingSet() from ctor v3: apply black to new test Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
|
Stress test (undefined, actions) - #38221 |
tavplubix
added
the
pr-must-backport
This was referenced Jun 29, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 29, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 29, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jun 29, 2022
tavplubix
added a commit
that referenced
this pull request
Jun 29, 2022
Backport #38486 to 22.4: ('Fix parts removal after incorrect server shutdown ',)
tavplubix
added a commit
that referenced
this pull request
Jun 29, 2022
Backport #38486 to 22.6: ('Fix parts removal after incorrect server shutdown ',)
tavplubix
added a commit
that referenced
this pull request
Jun 30, 2022
Backport #38486 to 22.5: ('Fix parts removal after incorrect server shutdown ',)
Felixoid
added
the
pr-backports-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix parts removal (will be left forever if they had not been removed on server shutdown) after incorrect server shutdown
Before this patch, and after transaction support had been added #24258,
if the server had not removed old parts on shutdown, then they will left
forever.
Fixes: #24258 (cc @tavplubix)