Remove logging from OvercommitTracker to avoid deadlocks #39030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-bugfix
novikd
added
the
pr-must-backport
tavplubix
approved these changes
Jul 8, 2022
|
LGTM |
This was referenced Jul 9, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 9, 2022
novikd
added a commit
that referenced
this pull request
Jul 11, 2022
Backport #39030 to 22.6: Remove logging from OvercommitTracker to avoid deadlocks
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 11, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 11, 2022
novikd
added a commit
that referenced
this pull request
Jul 12, 2022
Backport #39030 to 22.3: Remove logging from OvercommitTracker to avoid deadlocks
novikd
added a commit
that referenced
this pull request
Jul 12, 2022
Backport #39030 to 22.5: Remove logging from OvercommitTracker to avoid deadlocks
Felixoid
added
the
pr-backports-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Any allocations inside OvercommitTracker may lead to deadlock. Logging was not very informative so it's easier just to remove logging. Fixes #37794
cc @tavplubix @azat