Add support for LARGE_BINARY/LARGE_STRING with Arrow #40293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robot-clickhouse
added
the
pr-improvement
yakov-olkhovskiy
added
the
can be tested
yakov-olkhovskiy
approved these changes
Aug 17, 2022
Avogar
requested changes
Aug 17, 2022
Avogar
approved these changes
Aug 17, 2022
|
Thanks so much for cleaning this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for LARGE_UTF8 with Arrow. See the issue here #32401 for a full rundown of how to replicate this issue is there.
Unsure of how to add a test for this, I think we might need to change
test.arrowto add a LARGE_UTF8 column there, and also for Parquet. Thoughts?Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for LARGE_BINARY/LARGE_STRING with Arrow (Closes #32401)