Increase open files limit #41345
Merged
Increase open files limit #41345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-not-for-changelog
nikitamikhaylov
added
can be tested
alexey-milovidov
approved these changes
Sep 16, 2022
|
This is not a bug fix. |
|
Customer needs it to be backported in 22.6 |
This was referenced Sep 16, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 16, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 16, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 16, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 16, 2022
robot-ch-test-poll1
added
the
pr-backports-created
nikitamikhaylov
pushed a commit
that referenced
this pull request
Sep 16, 2022
nikitamikhaylov
pushed a commit
that referenced
this pull request
Sep 16, 2022
nikitamikhaylov
pushed a commit
that referenced
this pull request
Sep 16, 2022
azat
reviewed
Sep 28, 2022
| "{0}\tsoft\tnofile\t262144\n" | ||
| "{0}\thard\tnofile\t262144\n", user); | ||
| "{0}\tsoft\tnofile\t1048576\n" | ||
| "{0}\thard\tnofile\t1048576\n", user); |
There was a problem hiding this comment.
I think nowadays systemd is kind of defacto standard.
And for systemd it is better to use LimitNOFILE=1048576 systemd unit directive.
Yes systemd does interpret /etc/security too, but only if it has been configured with PAM (although I guess all major distributives does so), and limits from the unit (LimitNOFILE, ...) will override these.
And right now limit in systemd is 500K -
yokofly
added a commit
to timeplus-io/proton
that referenced
this pull request
Apr 10, 2024
1. increase open files limit. ClickHouse/ClickHouse#41345 2. use stringview instead char* 3. maybe better for throw exception 4. try take a hardlink first before copy. ClickHouse/ClickHouse#48578
jovezhong
added a commit
to timeplus-io/proton
that referenced
this pull request
Apr 10, 2024
…the locked /usr/bin (#651) * Update Install.cpp /usr/bin is locked on Mac. Change it to /usr/local/bin. This should also work on Linux * 2 more usr/bin to usr/local/bin * minor clean: 1. increase open files limit. ClickHouse/ClickHouse#41345 2. use stringview instead char* 3. maybe better for throw exception 4. try take a hardlink first before copy. ClickHouse/ClickHouse#48578 * conditional compile * fix the incorrect usage, the default is usr/bin otherwise only tag for macOS --------- Co-authored-by: yoko <haohang.shi@timeplus.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):