Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose correct aggregation method for lc128 and lc256 #42342

Merged
merged 7 commits into from Oct 18, 2022
Merged

Choose correct aggregation method for lc128 and lc256 #42342

merged 7 commits into from Oct 18, 2022

Conversation

canhld94
Copy link
Contributor

@canhld94 canhld94 commented Oct 16, 2022 •
edited by vdimir

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Choose correct aggregation method for LowCardinality with BigInt

Close #42330

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Oct 16, 2022
@vdimir vdimir added can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default and removed pr-improvement Pull request with some product improvements labels Oct 16, 2022
vdimir
vdimir approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vdimir vdimir self-assigned this Oct 16, 2022
@alexey-milovidov alexey-milovidov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 16, 2022
@alexey-milovidov
Copy link
Member

@azat @vdimir any idea why it didn't simply use AggregatedDataVariants::Type::serialized?

@alexey-milovidov alexey-milovidov changed the title Choose correct aggregation method for lc128 and lc512 Choose correct aggregation method for lc128 and lc256 Oct 16, 2022
@azat
Copy link
Collaborator

azat commented Oct 16, 2022

any idea why it didn't simply use AggregatedDataVariants::Type::serialized?

There is optimization for LowCardinality , that had been added in #3138

@canhld94
Copy link
Contributor Author

Fail cases:

  • Stateless: 00463_long_sessions_in_http_interface
  • msan: OOM kill, not sure...
  • tsan: backward compatibility,
  • ubsan: backward compatibility, cannot attach table

@vdimir vdimir merged commit 76b1020 into ClickHouse:master Oct 18, 2022
This was referenced Oct 18, 2022
Merged
Merged
Merged
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 18, 2022
Backport #42342 to 22.3: Choose correct aggregation method for lc128 …
c40a112 
…and lc256
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 18, 2022
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 18, 2022
Backport #42342 to 22.7: Choose correct aggregation method for lc128 …
d7683af 
…and lc256
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 18, 2022
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 18, 2022
Backport #42342 to 22.8: Choose correct aggregation method for lc128 …
01329fd 
…and lc256
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 18, 2022
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 18, 2022
Backport #42342 to 22.9: Choose correct aggregation method for lc128 …
ee6d1f5 
…and lc256
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 18, 2022
alexey-milovidov added a commit that referenced this pull request Oct 18, 2022
@alexey-milovidov
Merge pull request #42434 from ClickHouse/backport/22.8/42342
aadfbf2 
Backport #42342 to 22.8: Choose correct aggregation method for lc128 and lc256
alexey-milovidov added a commit that referenced this pull request Oct 18, 2022
@alexey-milovidov
Merge pull request #42435 from ClickHouse/backport/22.9/42342
5ce82f3 
Backport #42342 to 22.9: Choose correct aggregation method for lc128 and lc256
alexey-milovidov added a commit that referenced this pull request Oct 18, 2022
@alexey-milovidov
Merge pull request #42433 from ClickHouse/backport/22.7/42342
9d612af 
Backport #42342 to 22.7: Choose correct aggregation method for lc128 and lc256
alexey-milovidov added a commit that referenced this pull request Oct 18, 2022
@alexey-milovidov
Merge pull request #42432 from ClickHouse/backport/22.3/42342
57cae53 
Backport #42342 to 22.3: Choose correct aggregation method for lc128 and lc256
ucasfl pushed a commit to ucasfl/ClickHouse that referenced this pull request Nov 30, 2022
@vdimir
Merge pull request ClickHouse#42342 from canhld94/ch_canh_fix_aggrega…
338a80e 
…tor_lc
ucasfl pushed a commit to ucasfl/ClickHouse that referenced this pull request Nov 30, 2022
Merge branch 'bugfix-cherry-pick' into 'weolap-master-22-8' (merge re…
81bf845 
…quest !58)

bugfix-cherry-pick
Merge pull request ClickHouse#42198 from ClickHouse/fix-projections
ClickHouse#42499

ClickHouse#42342

ClickHouse#42384
ClickHouse#42198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azat azat azat left review comments

@vdimir vdimir vdimir approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@vdimir vdimir

Labels
can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use-of-uninitialized-value in DB::Aggregator
5 participants
@canhld94 @alexey-milovidov @azat @vdimir @robot-clickhouse