Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply preallocation optimisation more carefully #44455

Conversation

nickitat
Copy link
Member

@nickitat nickitat commented Dec 20, 2022

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Now optimisation is applied only if the cached HT size is sufficiently large (thresholds were determined empirically and hardcoded).

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-improvement Pull request with some product improvements label Dec 20, 2022
@nickitat nickitat linked an issue Dec 20, 2022 that may be closed by this pull request
@nickitat nickitat changed the title Skip HT preallocation optimisation for single thread and small table Apply preallocation optimisation more carefully Jan 3, 2023
@nickitat nickitat added the pr-performance Pull request with some performance improvements label Jan 3, 2023
@robot-ch-test-poll4 robot-ch-test-poll4 removed the pr-performance Pull request with some performance improvements label Jan 3, 2023
@nickitat nickitat added the pr-performance Pull request with some performance improvements label Jan 4, 2023
@robot-ch-test-poll1 robot-ch-test-poll1 removed the pr-improvement Pull request with some product improvements label Jan 4, 2023
@nickitat nickitat marked this pull request as ready for review January 5, 2023 11:49
@SmitaRKulkarni SmitaRKulkarni self-assigned this Jan 6, 2023
Copy link
Member

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preallocation into hash table slows down query for small table
4 participants