-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply preallocation optimisation more carefully #44455
Merged
nickitat
merged 6 commits into
ClickHouse:master
from
nickitat:apply_preallocation_optimisation_carefully
Jan 9, 2023
Merged
Apply preallocation optimisation more carefully #44455
nickitat
merged 6 commits into
ClickHouse:master
from
nickitat:apply_preallocation_optimisation_carefully
Jan 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll4
added
the
pr-improvement
Pull request with some product improvements
label
Dec 20, 2022
nickitat
changed the title
Skip HT preallocation optimisation for single thread and small table
Apply preallocation optimisation more carefully
Jan 3, 2023
robot-ch-test-poll4
removed
the
pr-performance
Pull request with some performance improvements
label
Jan 3, 2023
robot-ch-test-poll1
removed
the
pr-improvement
Pull request with some product improvements
label
Jan 4, 2023
SmitaRKulkarni
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now optimisation is applied only if the cached HT size is sufficiently large (thresholds were determined empirically and hardcoded).