Fix too aggressive evaluation of args in default column expr #44547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll4
added
the
pr-bugfix
Avogar
approved these changes
Jan 13, 2023
|
Can you look at the Fast test failure? |
|
Yep, I'm looking at it right now :) |
|
Stress test (asan) - #45308 |
tavplubix
added
the
pr-must-backport
This was referenced Jan 16, 2023
Closed
Closed
Closed
Closed
robot-ch-test-poll3
added
the
pr-backports-created
tavplubix
added a commit
that referenced
this pull request
Jan 17, 2023
Backport #44547 to 22.12: Fix too aggressive evaluation of args in default column expr
vitlibar
reviewed
Feb 7, 2023
| if (!args || args->children.size() != 2) | ||
| return -1; | ||
|
|
||
| if (args->children[1]->as<ASTFunction>()) |
There was a problem hiding this comment.
@tavplubix You're checking only for ASTFunction here but what if the second argument of IN is a subquery? Like x IN (SELECT id FROM tbl). SELECT id FROM tbl isn't a function but it seems it doesn't need to be evaluated during normalization.
There was a problem hiding this comment.
Oh I see
- there is another check forASTFunction so the normalization evaluates only functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed a bug in normalization of a
DEFAULTexpression inCREATE TABLEstatement. The second argument of functionin(or the right argument of operatorIN) might be replaced with the result of its evaluation during CREATE query execution. Fixes #44496