Fix bug with wrong type in Merge table and PREWHERE #44716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-2
added
the
pr-bugfix
vdimir
commented
Dec 30, 2022
SmitaRKulkarni
approved these changes
Dec 30, 2022
1 task
azat
reviewed
Feb 15, 2023
| if (!can_move) | ||
| return false; | ||
|
|
||
| if (!getInMemoryMetadataPtr()) |
There was a problem hiding this comment.
Hi @vdimir. Is this at all possible? setInMemoryMetadata in StorageMerge should be enough, no?
There was a problem hiding this comment.
@azat yes, this check is excessive
There was a problem hiding this comment.
I've removed it here - #46454, it also addresses few other issues with PREWHERE for Merge, and this patch makes it possible to use PREWHERE for columns which types is the same, instead of globally disable PREWHERE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug with wrong type in Merge table and PREWHERE, close #43324