Catch exceptions in BackgroundSchedulePool #44923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw the case when one of users of BackgroundSchedulePool (DirectoryMonitor for async INSERT into Distributed table) throws (in a very unlikely scenaior, which wich ClickHouse#44922 may help), and this case the task is leaved in an undefined state, and instead of fix this I put assert to catch such code instead. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
robot-clickhouse
added
the
pr-not-for-changelog
alexey-milovidov
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Catch exceptions in BackgroundSchedulePool
I saw the case when one of users of BackgroundSchedulePool (DirectoryMonitor for async INSERT into Distributed table) throws (in a very unlikely scenario, which which #44922 may help), and this case the task is leaved in an undefined state, and instead of fix this I put assert to catch such code instead.
This is less significant then #27428, and should not introduce issues like #27812