Binary arithmetic for IPv4 #45150
Merged
Binary arithmetic for IPv4 #45150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-bugfix
novikd
reviewed
Jan 11, 2023
| @@ -1209,6 +1213,17 @@ class FunctionBinaryArithmetic : public IFunction | |||
| return arguments[0]; | |||
| } | |||
|
|
|||
| /// Special case - one or both arguments are IPv4 | |||
| if (isIPv4(arguments[0]) || isIPv4(arguments[1])) | |||
There was a problem hiding this comment.
Needs a test, I am almost sure that it's always false.
There was a problem hiding this comment.
Actually, function isIPv4 is not connected with the template above :) It's
inline bool isIPv4(const DataTypePtr & data_type) { return WhichDataType(data_type).isIPv4(); } so should work aifak.
Test is added, I will merge.
|
This looks like ready? |
|
It's strange that |
I guess because the bug was never released. |
lizhou1111
added a commit
to timeplus-io/proton
that referenced
this pull request
Dec 12, 2023
yl-lisen
pushed a commit
to timeplus-io/proton
that referenced
this pull request
Dec 12, 2023
* binary arithmetic for IPv4, porting ClickHouse/ClickHouse#45150 * add more test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Follow-up fix for Replace domain IP types (IPv4, IPv6) with native #43221