Window view functional test failed on platform s390x #45375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-improvement
yakov-olkhovskiy
added
the
can be tested
src/Interpreters/Aggregator.h
Outdated
Comment on lines
212
to
215
| FieldType casted_key = static_cast<FieldType>(key); | ||
| const auto * key_holder = reinterpret_cast<const char *>(&casted_key); | ||
| auto * column = static_cast<ColumnVectorHelper *>(key_columns[0]); | ||
| column->insertRawData<sizeof(FieldType)>(key_holder); |
There was a problem hiding this comment.
It's not a good solution - at least it should be under if constexpr or #ifdef for endianness, but I would consider option to add offset to key_holder if sizeof(FieldType) < sizeof(Key)
also, I'm not sure if there can't be a case sizeof(Key) < sizeof(FieldType) - it will be not good...
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
1 task
yakov-olkhovskiy
approved these changes
Feb 2, 2023
|
@Mergifyio update |
|
@SuzyWangIBMer could you please update your branch with master? we had some issues there which were fixed I hope... |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
in the case key casted from uint64 to uint32, small impact for little endian platform but key value becomes zero in big endian case.
Documentation entry for user-facing changes