Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: return unsorted array element in quantile function #45379

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

wujunfu
Copy link
Contributor

@wujunfu wujunfu commented Jan 18, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix functions (quantilesExactExclusive, quantilesExactInclusive) return unsorted array element.

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2023

CLA assistant check
All committers have signed the CLA.

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Jan 18, 2023
@wujunfu wujunfu marked this pull request as ready for review January 18, 2023 03:27
@wujunfu
Copy link
Contributor Author

wujunfu commented Jan 18, 2023

@CurtizJ @serxa
Hi, could you help me add "can be tested" label ?

@yakov-olkhovskiy yakov-olkhovskiy added the can be tested Allows running workflows for external contributors label Jan 18, 2023
@yakov-olkhovskiy yakov-olkhovskiy self-assigned this Jan 18, 2023
@yakov-olkhovskiy
Copy link
Member

@wujunfu nice catch, though std::max_element std::mix_element return iterator - you need to dereference it...

@yakov-olkhovskiy yakov-olkhovskiy merged commit 1167d2c into ClickHouse:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants