Updated backup/restore status when concurrent backups & restores are not allowed #45497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not allowed Implementation: * Moved concurrent backup/restore check inside try-catch block which sets the status so that other nodes in cluster are aware of failures. * Renamed backup_uuid to restore_uuid in RestoreSettings. Testing: * Updated test test_backup_and_restore_on_cluster/test_disallow_concurrency to check for specific backup/restore id.
… when concurrent backups & restores are not allowed
hanfei1991
approved these changes
Jan 23, 2023
vitlibar
reviewed
Jan 24, 2023
vitlibar
reviewed
Jan 24, 2023
…atus when concurrent backups & restores are not allowed
…rrent_backups_restores
…rrent_backups_restores
vitlibar
reviewed
Jan 24, 2023
vitlibar
approved these changes
Jan 24, 2023
…s/Restores - Updated backup/restore status when concurrent backups & restores are not allowed
vitlibar
approved these changes
Jan 24, 2023
hanfei1991
approved these changes
Jan 24, 2023
|
Failures are unrelated |
SmitaRKulkarni
deleted the
45486_Fix_flaky_test_for_disallowing_concurrent_backups_restores
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Updated backup/restore status when concurrent backups & restores are not allowed resolves #45486
Implementation:
Testing: