Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
I have found out here that CH uses wal on S3 disk in tests.
It makes not much sence. It's better to write compact parts instead. Furthermore CH do not use such combination in real work.
In test I see that wal needs to be sync often in order to fulfill the assignment and be robust with restarts.
It is not possible to sync writing in S3. It is possible either finish the file or continue writing in it without fixation of written file part. Interesting fact: rotation works for fixation written file part much better Instead of sync.
I'm going to collect what test is failed and turn them off for s3-disks and other remote disks.